Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR for Vue.js 3 + Vite test demo #31

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Add PR for Vue.js 3 + Vite test demo #31

merged 2 commits into from
Sep 29, 2024

Conversation

sophiebremer
Copy link
Member

Based on PR #30 by @pcccccc

@sophiebremer
Copy link
Member Author

Thank you for your contribution, @pcccccc!

Please review the final merge. Let me know, if the name in the AUTHORS.md should be modified (or removed).

@pcccccc
Copy link
Contributor

pcccccc commented Aug 12, 2024

Hello, I have checked and it's running normally. Could you provide me with the table structure for iCloud.org.netzkonform.CloudKitTS? I'd like to continue improving the insert, select, update, delete functionality in the demo.

@sophiebremer sophiebremer marked this pull request as ready for review August 18, 2024 15:36
@sophiebremer
Copy link
Member Author

Hello, thank for the review!

A full demo goes beyond the goal of this package. The container is empty without any records. It just exists to test that Apple's code matches the TypeScript declarations and runs.

You might consider creating a Vue boiler plate repository, that can be linked from the readme file in this package.

BTW Apple has created it's own demo for CloudKit JS:

@pcccccc
Copy link
Contributor

pcccccc commented Aug 19, 2024

Hello, thank for the review!

A full demo goes beyond the goal of this package. The container is empty without any records. It just exists to test that Apple's code matches the TypeScript declarations and runs.

You might consider creating a Vue boiler plate repository, that can be linked from the readme file in this package.

BTW Apple has created it's own demo for CloudKit JS:

OK, Thank you

@sophiebremer sophiebremer added this to the v0.2.34 milestone Sep 29, 2024
@sophiebremer sophiebremer added the Feature Implementation Pull request that implements a new feature label Sep 29, 2024
@sophiebremer sophiebremer merged commit 004d632 into main Sep 29, 2024
2 checks passed
@sophiebremer sophiebremer deleted the feature/vue branch September 29, 2024 07:30
@sophiebremer sophiebremer mentioned this pull request Sep 29, 2024
5 tasks
@sophiebremer
Copy link
Member Author

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Implementation Pull request that implements a new feature
Development

Successfully merging this pull request may close these issues.

2 participants