Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support apple silicon #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PupilTong
Copy link

@PupilTong PupilTong commented Jan 4, 2023

Change Summary

  • use chromium-browser & chromium-chromedriver, since the chrome PPA dose not support arch=arm64.
  • lock pipenv version to avoid a crash on pipenv install. This is a pipenv bug.

fix #19

PR Checklist

* use `chromium-browser` & `chromium-chromedriver`, since the chrome PPA dose not support arch=arm64.
* lock pipenv version to avoid a crash on `pipenv install`. This is a pipenv bug.
@jasonbosco
Copy link
Member

jasonbosco commented Feb 11, 2023

@PupilTong I merged another PR which had a few related changes. Mind resolving the conflicts for this PR? I can then merge this in.

@PupilTong
Copy link
Author

@PupilTong I merged another PR which had a few related changes. Mind resolving the conflicts for this PR? I can then merge this in.

will double check the new dockerfile to resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker image for Apple silicon (arm64)?
2 participants