Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update codecov #2556

Merged
merged 1 commit into from
Nov 26, 2024
Merged

ci: update codecov #2556

merged 1 commit into from
Nov 26, 2024

Conversation

haiweilian
Copy link
Contributor

@haiweilian haiweilian commented Nov 21, 2024

Description

We don't need to change the Token. using codecov-action@v5 works successfully. This is consistent with its previous behavior.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #2544

@haiweilian
Copy link
Contributor Author

@braaar This runs success. Update workflow?

Copy link
Member

@braaar braaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@braaar braaar merged commit b07bb16 into typestack:develop Nov 26, 2024
7 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: codecov GitHub action is failing
2 participants