Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use typeof operator to check function type #100

Merged
merged 3 commits into from
Jul 29, 2020

Conversation

sobolevn
Copy link
Contributor

@sobolevn sobolevn commented Jun 23, 2019

closes #99

@sobolevn
Copy link
Contributor Author

I am pretty sure that

[13:26:34] Requiring external module ts-node/register
SyntaxError: Unexpected token {
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/travis/build/typestack/typedi/node_modules/tslint/lib/formatters/codeFrameFormatter.js:20:20)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.

is not related to this change.

Copy link

@justinmchase justinmchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sobolevn
Copy link
Contributor Author

@pleerock friendly ping

@NoNameProvided NoNameProvided changed the title fix(ssr): fixes function equality, closes #99 fix: use typeof operator to check function type Jul 29, 2020
@NoNameProvided NoNameProvided merged commit 4143afb into typestack:master Jul 29, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SSR issue
3 participants