Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyword parameters for Ruby 2.7+ #174

Closed
wants to merge 2 commits into from
Closed

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Feb 1, 2021

And add WEBrick dependency for Ruby 3.0

voxik added 2 commits February 1, 2021 18:48
WEBrick was completely removed from Ruby starting with Ruby 3.0.
@voxik
Copy link
Contributor Author

voxik commented Feb 2, 2021

The test failure is quite certainly related to this PR. Nevertheless, there are failing Ruby 1.8.7, 1.9.2 and 1.9.3 which are EOL for quite some time. I'd rather see the most recent version of Ruby supported.

@Kjarrigan
Copy link
Member

Thanks @voxik for the MR. I adjusted the travis matrix and cherry-picked your commits into #175

@Kjarrigan Kjarrigan closed this Feb 5, 2021
@Kjarrigan Kjarrigan mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants