Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #283: Support non-production Accounts API #285

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

danepowell
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d106876) compared to base (080658d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      codecov/codecov-action#285   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       253       255    +2     
===========================================
  Files             88        88           
  Lines           1079      1084    +5     
===========================================
+ Hits            1079      1084    +5     
Impacted Files Coverage Δ
src/Connector/Client.php 100.00% <100.00%> (ø)
src/Connector/Connector.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danepowell
Copy link
Collaborator Author

@typhonius your Coveralls token appears to be broken yet again, could you please help? 😄

@typhonius
Copy link
Owner

@typhonius your Coveralls token appears to be broken yet again, could you please help? 😄

👀

typhonius pushed a commit that referenced this pull request Nov 5, 2022
typhonius pushed a commit that referenced this pull request Nov 5, 2022
typhonius added a commit that referenced this pull request Nov 5, 2022
@typhonius typhonius closed this in 080658d Nov 5, 2022
@typhonius typhonius reopened this Nov 5, 2022
@typhonius
Copy link
Owner

Back to you @danepowell - github actions for codecov needed an update to a supported version (#286)

@danepowell
Copy link
Collaborator Author

Ugh... looks like the the codecov failures are basically an outage due to rate limiting and not something we can work around (other than to disable codecov entirely): codecov/feedback#126

I'll retry the action a few times and see what happens

@danepowell danepowell merged commit f11f4c1 into typhonius:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov suddenly stopped working
2 participants