Fix #321: PHP 7.4 EOL #323
Conversation
| @@ -9,7 +9,7 @@ | |||
| ], | |||
| "license": "MIT", | |||
| "require": { | |||
| "php": "^7.4 | ^8.0.2 | ^8.1 | ^8.2", | |||
There was a problem hiding this comment.
8.0.2 was added in #225, I can find no justification for the oddly-specific constraint. Possibly it was just the latest version at the time. Anyway, the specificity of it conflicts with the config php definition below.
| @@ -10,8 +10,5 @@ parameters: | |||
| - | |||
| message: '%Parameter #1 \$client of method League\\OAuth2\\Client\\Provider\\AbstractProvider::setHttpClient\(\) expects GuzzleHttp\\ClientInterface, Eloquent\\Phony\\Mock\\Mock given.%' | |||
| path: tests/Connector/ConnectorTest.php | |||
| - | |||
| # https://github.com/phpstan/phpstan/issues/1066 | |||
There was a problem hiding this comment.
No longer necessary due to psr/cache upgrade
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 257 257
===========================================
Files 88 88
Lines 1695 1695
===========================================
Hits 1695 1695 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@typhonius I would suggest modifying the branch protections to only require the mutation job and new "check" job, which in turn will require all CI jobs to pass. I prefer this pattern because you don't have to keep updating branch protection settings every time a PHP version changes. |
|
@typhonius can you fix the branch protections so this can be merged (as suggested above), or give me admin access to do so? Thanks! |
Thanks for your work on this @danepowell. The name
|
|
@typhonius try again. That UI only shows jobs that ran in the past week; I updated this PR which should trigger the 'check' job to show up momentarily. |
Awesome thanks for that, it should be set correctly now. |
Fix #321