Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #336: Remove constructor from ConnectorInterface #337

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

danepowell
Copy link
Collaborator

Fix #336

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (04dfc2c) compared to base (23bfe16).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #337   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       257       257           
===========================================
  Files             88        88           
  Lines           1695      1695           
===========================================
  Hits            1695      1695           
Impacted Files Coverage Δ
src/Connector/Connector.php 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danepowell danepowell merged commit 1aa3596 into typhonius:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does the ConnectorInterface need to define __construct?
1 participant