Add flag to fix relativeUserPkgDir #728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantee
reviewed
Jun 11, 2020
README.md
Outdated
| @@ -328,6 +328,10 @@ npm install husky --save-dev | |||
|
|
|||
| Verify that your version of Git is `>=2.13.0`. | |||
|
|
|||
| #### Lerna Workspaces and Monorepos | |||
There was a problem hiding this comment.
Seems like this fix would also address this happening in a Yarn Workspaces monorepo. Maybe we should call that out?
There was a problem hiding this comment.
Changed to Lerna, Monorepos, and Yarn Worksapces to cover everything. What do you think?
There was a problem hiding this comment.
Thanks :) Already updated the PR, what is your merge process?
There was a problem hiding this comment.
First lets recreate the issue on master:
- close this example of a basic Lerna monorepo https://github.com/reggi/lerna-tutorial
- Setup Husky
- Run
yarninsidepackages/usage - Open
.git/hooks/huskey.local.sh, expect to seecd "packages/usage"// <-- this is the problem
Test the fix
- Checkout this PR in the example project
- Set the env variable
HUSKY_RUN_FROM_ROOT="true"orHUSKY_RUN_FROM_ROOT="1" - Remove
.git/hooks - Run
yarninsidepackages/usage - Open
.git/hooks/huskey.local.sh, expect to seecd "."// <-- this is the fix
There was a problem hiding this comment.
Piniging @lessen-inc and @typicode for their attention :)
|
hey just bumping this, any reason why it hasn't been merged? @typicode @lessen-inc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Per #677, and @eduard-malakhov great explanation #677 (comment)
Fix a bug when running
yarn|npm installfrom a subnode_modulesin a monorepo/yarn workspaces project.Current: the relative path to the project's root is set no
packages/someOtherwhen running from a package likepackages/someOther.Expected: To be able to force the relative path to the be the root of the project even when the
yarn|npm installis running not from the root.