Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade find versions to 4.0.0 #836

Closed

Conversation

k0nserv
Copy link

@k0nserv k0nserv commented Dec 31, 2020

find-versions 4.0.0 depends on ^3.1.2 of semver-regex. Previous
versions of semver-regex contained a vulnernability. This was
unlikely to affect husky because of how find-versions is used, but
the only breaking change in find-versions is increasing the minimum
Node.js verison to 10, which is the same as Husky's minimum.

`find-versions` 4.0.0 depends on `^3.1.2` of `semver-regex`. Previous
versions of `semver-regex` contained a [vulnernability][0]. This was
unlikely to affect `husky` because of how `find-versions` is used, but
the only breaking change in `find-versions` is increasing the minimum
Node.js verison to 10, which is the same as Husky's minimum.

[0]: https://app.snyk.io/vuln/SNYK-JS-SEMVERREGEX-1047770
@k0nserv k0nserv changed the base branch from next to master December 31, 2020 11:19
@k0nserv
Copy link
Author

k0nserv commented Dec 31, 2020

Closing due to incorrect base branch

@k0nserv k0nserv closed this Dec 31, 2020
@k0nserv k0nserv deleted the upgrade-find-versions-to-4.0.0 branch January 7, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant