-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package.json: Add repository url field #1511
Conversation
This is to make package homepage discoverable in npm index: - https://www.npmjs.com/package/json-server
Thank you! |
"repository": { | ||
"type": "git", | ||
"url": "git+https://github.com/typicode/json-server.git" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argh. fcking code style again.
i made edit from web, copied from husky package.json and fixed path.
i guess here can be no git hooks to prevent it, it should be formatted on CI pipeline and aborted if mismatch.
you didn't not notice this yourself when looking diffs in github files view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm doing it on my phone on the GitHub app lol and I still don't see the issue. It's not published so it's fine. Thanks for the heads up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, the tabs I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think any command that updates package.json
like npm version
npm install
should fix it (which happen fairly often with v1 work). You can make a PR or leave it as it is, as you prefer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let you to finish it :)
however,
I just randomly read husky install code. and you may not like what it does. the way I read it out is if it finds single tab in the file it will format whole file with tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make package homepage discoverable in npm index: