Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add css variable support #39

Closed
wants to merge 3 commits into from

Conversation

The-Code-Monkey
Copy link
Contributor

@The-Code-Monkey The-Code-Monkey commented Apr 3, 2024

from what i found before doing

&[data-size="sm"] didnt work but &[data-size='sm'] did so i updated the regex string to support double quotes.

this PR also now adds variable support. Might need a custom css.d.ts file if the as string is not wanted, just due to react not liking inline variables as they are not part of CSSType yet.

fixes #36
fixes #40

@The-Code-Monkey The-Code-Monkey changed the title fix: allow double quotes in css data-attribute tags Feat: add css variable support Apr 4, 2024
@The-Code-Monkey
Copy link
Contributor Author

@typicode let me know your thoughts and I'll do any tweaks if you want any doing

@typicode
Copy link
Owner

typicode commented Apr 5, 2024

Thanks for the PR. I feel that things with the current codebase are getting quite complex.

I plan to rewrite the parsing code, I think it can be improved. Also, I will re-organize a few things in preparation of other features.

Since tests are passing, I can merge it and release a new version if you need it?

@The-Code-Monkey
Copy link
Contributor Author

@typicode yeah I understand, I did need this, but it's up to you whether to merge something like this now or add it when you rebuild things

@The-Code-Monkey
Copy link
Contributor Author

@typicode any update on this as I have some other things I'd like to suggest but I have built them on top of this pr

@typicode
Copy link
Owner

I'm making good progress, but I'd like to rewrite docs and iron things out before releasing the next version.

@The-Code-Monkey
Copy link
Contributor Author

@typicode of course no worries. The only other thing I came across and fixed was I added a list of html element that don't support child element so I added that logic in.

@The-Code-Monkey
Copy link
Contributor Author

I will wait for your rewrite before trying to add anything else

@The-Code-Monkey
Copy link
Contributor Author

closing due to further work needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants