Added jointjs typings

[CaselIT]

Filling in these fields will make it easier for us to review:

Typings URL: [E.g. https://github.com/CaselIT/typings-jointjs]
Source URL: [E.g. https://github.com/clientIO/joint]

Thanks for contributing!

[unional]

Correction:
https://github.com/CaselIT/typings-jointjs/blob/master/index.d.ts
Does it only exposing g and v?

[CaselIT]

No it exposes also the objects dia ui shapes util and layout

[unional]

Oh, interesting. Never know it works that way. Thanks.

[unional]

It's ES6 -> CommonJS interop

[CaselIT]

I'm not sure I follow. Do you mean the missing exports in the namespace declaration?

[unional]

Nope. I tested it and it is working.
jointjs is using export = syntax at index.js, and what you have is in ES6 syntax. So it is a ES6 -> CommonJS interop.

[unional]

Not sure if that is a good idea to do so, as it might backfire as the CommonJS -> ES6 interop issue.
I think there are some ES6->CommonJS interop trick babel is doing.
But I guess this would be fine.

@blakeembrey , what do you think?

[unional]

@CaselIT you probably aware of it, but for reference, what I'm talking about is related to:
microsoft/TypeScript#7398

[CaselIT]

I was not aware of it, thanks for pointing it out. I think I did experience something similar while writing the type definition for this library. If load this library with system.js as global the external module as it is written is incorrect, while it works when loading it as commonjs.
Still I think most people will use the ambient definitions and load the library with a script tag.
Do you have any advice to avoid the issue?

[unional]

Still I think most people will use the ambient definitions and load the library with a script tag

Loading from script tag just means the typings needs to be ambient/global/script. So the /global/* should take care of it.

Do you have any advice to avoid the issue?

Currently no, unfortunately. That why I think the issue is massive. The best we can do is to stay as close to the shape of the source as possible.

i.e. in this case keep it in the export = syntax.

[CaselIT]

I tried to change the type definition, did you mean like they are now? They effectively are as before.

https://github.com/CaselIT/typings-jointjs/blob/test-export/index.d.ts

If this was what you meant, wait before merging so I can update the pull request with the new commit.

[unional]

yup. 👍

[CaselIT]

I've updated the pull request.

[unional]

FYI Having some difficulty to merge

[CaselIT]

Can I help?

[unional]

It's related to the repo setting I think. So need @blakeembrey's help on it.

[CaselIT]

I can re-fork the repo and risubmit the pull request if you think that it would help.

[unional]

Thanks. But it's not just your PR. Same for all other PRs. 😏

[blakeembrey]

Sorry, it appeared to be an odd restriction that comes with the enablement of the squash option. It should now be fixed for collaborators.