Cache Typst packages #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
jcbhmr
reviewed
Jan 25, 2024
There was a problem hiding this comment.
I think you need to use glob.hashFiles() across any files like package-lock.json or in this case **/*.typ to get a unique cache id. Then save to that instead of packages-id? Similar to https://github.com/actions/setup-node ? does that make sense?
as for the "vite doesn't work" you're absolutely 100% right. 😆 it workd great up until it didn't. https://bun.sh seems to work in this instance so i guess you can use that instead
i made a bunch of changes in #17 that i think you should check out and consider merging into this #16 branch 🤷
This comment was marked as outdated.
This comment was marked as outdated.
yusancky
commented
Jan 26, 2024
yusancky
commented
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.