Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to include .venv directory #80

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

kimushun1101
Copy link
Contributor

Signed-off-by: Shunsuke Kimura <kimushun1101@gmail.com>
@kimushun1101 kimushun1101 requested a review from 3w36zj6 November 24, 2024 09:33
.gitignore Outdated
@@ -31,3 +31,6 @@ package-lock.json
/assets/docs
/assets/docs.json
/dist

# mise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.venv/はPython標準のディレクトリであり、miseやuvに固有のものではないので、コメントを追加するのであれば「Python」や「Python environments」などがより適切だと思います。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上に# Rustがあったので# Pythonとしました。

Signed-off-by: Shunsuke Kimura <kimushun1101@gmail.com>
@3w36zj6 3w36zj6 changed the title MOD gitignore for venv directory Update .gitignore to include .venv directory Nov 24, 2024
@3w36zj6 3w36zj6 merged commit 878a8b3 into typst-jp:main Nov 24, 2024
1 check passed
@kimushun1101 kimushun1101 deleted the modify-gitignore-for-venv branch November 24, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants