-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to list the fonts detected #45
Conversation
fa1e0c6
to
43c10f1
Compare
Looks good to me! I'm sure it will be reviewed soon, it's just that the owners of this crate are pretty busy at the moment, so don't be surprised if it takes a while until they manage to review it. But they will review it eventually. 😄 |
Needs rebase/merge because of new crate structure. That aside, I'm not sure whether the PostScript name is the most user-friendly thing to print. We could also group by typographic family and print the available variants like |
43c10f1
to
9256a71
Compare
Rebased 👌 I can change the output no problem. However I am not sure what is the best overall, I just implemented what helped me with my use case. |
Hey! I think that stuff that does not change the behavior of the CLI but does something different altogether should be a subcommand, not a flag. I agree with @laurmaedje that the font families should be sorted by and displayed with their typographical families. I also get that showing PostScript names is useful, especially since the library is subject to two separate font resolution algorithms (CSS standalone and Typst/consumer). How about an output like this?
|
Yep, that sounds good! I can have a look at (Also, just keeping in mind that we're doing all of this to try to solve #44 🙃). |
c978ed6
to
e3f2a5d
Compare
Alright! I looked at There are now 2 commands, Here is the output of the And here the output of the Let me know what you think, and if this iteration matches what you had in mind. If for any reason that is not the case, just provide some pointers and I'll make the necessary adjustments. :) |
I would, if possible, prefer if |
No problem! I'll give it a shot :) |
6fab167
to
bf80296
Compare
Looks good! |
Adds a new CLI flag allowing the user to list the fonts which are detected on the system. Keep the pdf conversion as the default commandi. If no command is provided, an error message will be displayed. Signed-off-by: Rémy Greinhofer <remy.greinhofer@gmail.com>
bf80296
to
58625e5
Compare
@laurmaedje @reknih rebase complete ✅ |
Thank you for your work and patience! |
Adds a new CLI flag allowing the user to just list the fonts which are
detected on the system.
Signed-off-by: Rémy Greinhofer remy.greinhofer@gmail.com