Change SipHash2-4 -> SipHash1-3 #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to significantly improves performance. Inspired by rust-lang/rust#107925
|
Have you considered ahash, xxhash, fxhash, etc? |
|
No, I haven't. I'm really just mimiciing rustc's decision on the matter. I'm afraid I won't be able to test them out soon though (I'll be quite busy on the next days). |
At least fxhash doesn't have high-enough quality. We're relying on the fact that the collision probability for these 128-bit SipHashes is extremely low. If a collision happens, Typst might produce wrong results. |
elteammate
pushed a commit
to rabotaem-incorporated/opinionated-typst
that referenced
this pull request
Apr 19, 2023
This seems to significantly improves performance. Inspired by rust-lang/rust#107925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by rust-lang/rust#107925.
This seems to significantly improves performance.