Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accents not removed in Greek alphabet #52

Closed
mcsf opened this issue May 23, 2024 · 4 comments
Closed

Accents not removed in Greek alphabet #52

mcsf opened this issue May 23, 2024 · 4 comments

Comments

@mcsf
Copy link

mcsf commented May 23, 2024

Observed here: WordPress/gutenberg#61876 (comment)

> RA.remove( 'φιλε φίλε' )
'φιλε φίλε'

Expected output: φιλε φιλε.

Or at least that's what I expect as an outsider with only some knowledge of Greek.

@tyxla
Copy link
Owner

tyxla commented May 23, 2024

Good one - the accented Iota is definitely missing. Wanna file a PR? 😅

@tyxla
Copy link
Owner

tyxla commented May 23, 2024

It appears like a bunch more Greek diacritics exist and are missing. Could be a good addition to the existing supported characters.

@mcsf
Copy link
Author

mcsf commented May 23, 2024

I can give it a go at the end of the day, but I think I'll stick to just Modern Greek, which presents a smaller set of combinations to deal with :P

@mcsf
Copy link
Author

mcsf commented May 23, 2024

Actually, I just realised that compatibility with WordPress's remove_accents is important, and that function doesn't modify Greek diacritics (cf. source — don't be fooled by the alpha-looking thing, it's part of the Latin set).

So I'll close this one.

@mcsf mcsf closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants