Editor: Ensure Copy button in sidebar copies whole permalink, *with* URL protocol #61876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`usePostURLLabel` is meant to be used in labels and intentionally strips the protocol of a URL. As a result, the copy button in the `PostURL` component wrote something like "example.org/foobar" to the clipboard, instead of "https://example.org/foobar". As a fix, just grab the permalink directly.
mcsf
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +218 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 03f0364. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9206152426
|
ntsekouras
reviewed
May 22, 2024
| ( select ) => select( editorStore ).getPermalink(), | ||
| [] | ||
| ); | ||
| const copyButtonRef = useCopyToClipboard( permalink, () => { |
There was a problem hiding this comment.
We should also use safeDecodeURIComponent for the copied permalink.
There was a problem hiding this comment.
@ntsekouras: Is it needed in practice? I had a quick look at getPermalink, getPermalinkParts and I don't see where we'd get encoded components from. Also:
In the above scenario I see http://localhost:8881/2024/05/ola-φίλε/ in my clipboard, as expected.
Finally, I also just refactored to use the existing useSelect call in that component.
There was a problem hiding this comment.
Hm.. yesterday I tested with some greek and accents and it produced a URL that needed it. Don't remember what I tried exactly though and couldn't reproduce today with random tests, that could be similar to the yesterday ones..
There was a problem hiding this comment.
So I should just add the decoder to be safe?
mcsf
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
…URL protocol (WordPress#61876) * PostURL: Copy whole permalink, *with* protocol `usePostURLLabel` is meant to be used in labels and intentionally strips the protocol of a URL. As a result, the copy button in the `PostURL` component wrote something like "example.org/foobar" to the clipboard, instead of "https://example.org/foobar". As a fix, just grab the permalink directly. * Docs: Fix grammar * Fold permalink selection into existing useSelect call * Filter through safeDecodeURIComponent -- you never know
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…URL protocol (WordPress#61876) * PostURL: Copy whole permalink, *with* protocol `usePostURLLabel` is meant to be used in labels and intentionally strips the protocol of a URL. As a result, the copy button in the `PostURL` component wrote something like "example.org/foobar" to the clipboard, instead of "https://example.org/foobar". As a fix, just grab the permalink directly. * Docs: Fix grammar * Fold permalink selection into existing useSelect call * Filter through safeDecodeURIComponent -- you never know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usePostURLLabelis meant to be used in labels and intentionally strips the protocol of a URL. As a result, the copy button in thePostURLcomponent wrote something like "example.org/foobar" to the clipboard, instead of "https://example.org/foobar".As a fix, just grab the permalink directly.