Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeAccents micro-optimisation #16

Merged
merged 2 commits into from
Feb 12, 2018
Merged

removeAccents micro-optimisation #16

merged 2 commits into from
Feb 12, 2018

Conversation

Alorel
Copy link
Contributor

@Alorel Alorel commented Feb 11, 2018

Moved the matcher function outside so we don't have to create it every time we want to remove accents

Alorel and others added 2 commits February 11, 2018 18:00
@Alorel
removeAccents micro-optimisation
e78a782 
Moved the matcher function outside so we don't have to create it every time we want to remove accents
@tyxla
Use tabs for indentation
c4a684e
tyxla
tyxla approved these changes Feb 12, 2018
View reviewed changes
Copy link
Owner

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 👍 I've only updated the indentation to use tabs instead of spaces.

Thanks so much @Alorel! 💯

@tyxla tyxla merged commit 8a4f850 into tyxla:master Feb 12, 2018
@Alorel Alorel deleted the patch-1 branch February 12, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

Assignees

@Alorel Alorel

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alorel @tyxla