This repository has been archived by the owner on Oct 26, 2019. It is now read-only.

Notify clients of playlist cycle on advance #13

Closed

goto-bus-stop opened this issue Jan 16, 2016 · 0 comments

Labels

feature good first PR prio: high

Member

goto-bus-stop commented Jan 16, 2016

When someone starts DJing, their playlist "cycles", i.e. the first item is moved to the very end. A socket event (playlistCycle, perhaps) should be dispatched for this too, so clients also know to cycle their playlist.

Advance stuff happens here, for now:
https://github.com/goto-bus-stop/u-wave-api-v1/blob/8ad01591dfe77948312bbdbad3a72ba3066667d7/src/sockets.js#L222-L244

The text was updated successfully, but these errors were encountered:

goto-bus-stop added good first PR prio: high feature labels

goto-bus-stop closed this as completed

goto-bus-stop pushed a commit that referenced this issue


          Update escape-string-regexp to the latest version 🚀 (#302)

2d45995

## The dependency [escape-string-regexp](https://github.com/sindresorhus/escape-string-regexp) was updated from `1.0.5` to `2.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v2.0.0</summary>

<p>Breaking:</p>
<ul>
<li>Require Node.js 8 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="432845430" data-permission-text="Issue title is private" data-url="sindresorhus/escape-string-regexp#13" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/escape-string-regexp/pull/13/hovercard" href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/pull/13">#13</a>)  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/escape-string-regexp/commit/ea980986c69f1cd8dee3b65597852c6eeaf79430/hovercard" href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/commit/ea980986c69f1cd8dee3b65597852c6eeaf79430"><tt>ea98098</tt></a></li>
</ul>
<p>Enhancements:</p>
<ul>
<li>Also escape <code>-</code>  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/escape-string-regexp/commit/e76291d337900dbfba3b2e04d71c6d718ec7199b/hovercard" href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/commit/e76291d337900dbfba3b2e04d71c6d718ec7199b"><tt>e76291d</tt></a></li>
<li>Add TypeScript definition (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="432845430" data-permission-text="Issue title is private" data-url="sindresorhus/escape-string-regexp#13" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/escape-string-regexp/pull/13/hovercard" href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/pull/13">#13</a>)  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/escape-string-regexp/commit/ea980986c69f1cd8dee3b65597852c6eeaf79430/hovercard" href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/commit/ea980986c69f1cd8dee3b65597852c6eeaf79430"><tt>ea98098</tt></a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/compare/v1.0.5...v2.0.0"><tt>v1.0.5...v2.0.0</tt></a></p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 3 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/commit/21c557c7f14a112eebe196abd98d085f5fcfcf5e"><code>21c557c</code></a> <code>2.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/commit/e76291d337900dbfba3b2e04d71c6d718ec7199b"><code>e76291d</code></a> <code>Also escape <code>-</code></code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/commit/ea980986c69f1cd8dee3b65597852c6eeaf79430"><code>ea98098</code></a> <code>Require Node.js 8, add TypeScript definition (#13)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/sindresorhus/escape-string-regexp/compare/db124a3e1aae9d692c4899e42a5c6c3e329eaa20...21c557c7f14a112eebe196abd98d085f5fcfcf5e">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.