Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters not being applied on https://www.buzzfeed.com/ #1026

Closed
ryanbr opened this issue Dec 17, 2017 · 6 comments
Closed

Filters not being applied on https://www.buzzfeed.com/ #1026

ryanbr opened this issue Dec 17, 2017 · 6 comments

Comments

@ryanbr
Copy link
Contributor

ryanbr commented Dec 17, 2017

https://www.buzzfeed.com/chrisgeidner/the-trump-campaign-claims-a-federal-office-illegally-turned

Describe the issue

The following; ###mod-newsletter-signup-1 and ###mod-newsletter-signup-2 filters in Easylist aren't being applied, its like it had a $generichide element (which it doesn't).

Manually adding; works fine. But should be taken care of in exisitng filters

buzzfeed.com###mod-newsletter-signup-2
buzzfeed.com###mod-newsletter-signup-1

Trying to block the blue Newsletter div elements (right, and bottom).

Using Easylist, Easyprivacy, Annoyances.

ABP hides the elements without issue.

@mapx-
Copy link
Contributor

mapx- commented Dec 17, 2017

It seems only the generic div rules have this behaviour.
Tested a couple of other pages, no issues.
@gorhill

@gorhill
Copy link
Member

gorhill commented Dec 17, 2017

Duplicate of gorhill/uBlock#1885.

gorhill added a commit that referenced this issue Dec 17, 2017
gorhill added a commit to gorhill/uBlock that referenced this issue Dec 17, 2017
@ryanbr
Copy link
Contributor Author

ryanbr commented Dec 17, 2017

Okay, made a specific filter for uBo.

easylist/easylist@1edfbfd

@ryanbr ryanbr closed this as completed Dec 17, 2017
@gotitbro
Copy link

@ryanbr Interesting you added a filter specific to uBO in EasyList. From what I have known EasyList has always been ABP focused.

@smed79
Copy link
Contributor

smed79 commented Dec 19, 2017

EasyList has always been ABP focused

Not sure... easylist/easylist@2c64810cf29493560a33cb

@gotitbro
Copy link

@smed79 So what is the position here then. No uBO specific filter syntax have been added to EasyList but ABP ones have like :-abp-has.

And taking into account other blockers only uBO related filters have been added to EasyList. Looks like EasyList still only follows the ABP filter syntax but for some reason uBO filters are also being added @ryanbr.

@uBlockOrigin uBlockOrigin locked and limited conversation to collaborators Dec 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants