makemytrip.com: nuisance

[SeriousHoax]

Prerequisites

• This is NOT a YouTube, Facebook or Twitch report.
• I read and understand the policy about what is a valid filter issue.
• I verified that this issue is not a duplicate. (Search here to find out.)
• I forced an update of my filter lists. (Click the "Purge all caches" button while holding the 'Shift' key, then click the "Update now" button.)
• I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
• I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
• I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
• I am not using uBlock Origin (uBO) along with other content blocker extensions.
• I have verified that the web browser's built-in blocker or DNS blocking (standalone or through a VPN) is not causing the issue.
• I did not answer truthfully to ALL the above checkpoints.

URL(s) where the issue occurs.

https://www.makemytrip.com/

Description

Extra filters added: All EasyList Annoyances, uBO Annoyances.

Issues:
Login popups, missed ads, mobile app banner and others in case I missed something.

Adguard Tracking protection has this rule: ||jsak.mmtcdn.com/*/pwa_commons/pwatracker.js to block a tracker script, it seems. It's not blocked by the default EasyPrivacy. Create a rule for this also, if necessary.

Other extensions used

None

Screenshot(s)

Screenshot(s)

Configuration

Details

uBlock Origin: 1.53.0
Firefox: 119
filterset (summary):
 network: 108887
 cosmetic: 116137
 scriptlet: 25592
 html: 1288
listset (total-discarded, last-updated):
 added:
  easylist-annoyances: 4175-94, 21m
  easylist-chat: 153-0, 21m
  fanboy-cookiemonster: 48865-268, 21m
  ublock-cookies-easylist: 528-0, 21m
  easylist-newsletters: 6649-13, 21m
  easylist-notifications: 2872-4, 21m
  fanboy-social: 16194-7, 21m
  ublock-annoyances: 5771-563, 21m
 default:
  user-filters: 0-0, never
  ublock-filters: 36172-171, 21m
  ublock-badware: 7462-5, 21m
  ublock-privacy: 662-0, 21m
  ublock-unbreak: 2194-1, 21m
  ublock-quick-fixes: 181-7, 21m
  easylist: 75265-733, 21m
  easyprivacy: 32873-816, 21m
  urlhaus-1: 11000-0, 21m
  plowe-0: 3723-1, 21m
filterset (user): [empty]
userSettings: [none]
hiddenSettings: [none]
supportStats:
 allReadyAfter: 286 ms (selfie)
 maxAssetCacheWait: 147 ms
popupPanel:
 blocked: 15
 network:
  makemytrip.com: 10
  demdex.net: 3
  google.com: 1
  webengage.com: 1
 extended:
  ##.socialMediaLinks

[gorhill]

This seems to work:

makemytrip.com##.modalLogin

If so, should probably go in EasyList – Other Annoyances I guess.

---

Works for desktop version of the site. Investigating for mobile.

[gorhill]

For mobile:

makemytrip.com##.pwa-login
makemytrip.com##.appDnldOffers
makemytrip.com##body:style(overflow: unset !important)

---

And these:

Ad:

makemytrip.com##.adtech-desktop

Nuisances:

makemytrip.com##.switchToApp
makemytrip.com##.cm__allOverOverlay

---

More app download button:

makemytrip.com##.btmDnldApp

[ryanbr]

makemytrip.com##.modalLogin prevents the login window from occuring completely.

Is there something like, makemytrip.com##+js(trusted-set-session-storage-item, opd, \"1\") The item is wrapped in "" quotes

[gorhill]

I think this should work:

makemytrip.com##+js(trusted-set-session-storage-item, opd, '"1"')

[ryanbr]

Does trusted-session work? the highlight shows up; (on 1.53.5rc4)

[stephenhawk8054]

I don't think we have trusted version of set-session?

[gorhill]

I can add it in the current dev cycle, it's a trivial change.

[gorhill]

If it's because of the quotes, I think it would make sense to allow quotes around any of the supported values in plain set-local-storage-item / set-session-storage-item -- it's not like the quotes introduce a security issue.

[ryanbr]

Also set-cookie?

[gorhill]

I've added support for using quotes around supported values in set-(local|session)-storage-item and set-cookie, this will be in rc5 build.

[ryanbr]

trusted-session would be helpful. The actual session value used on makemytrip is "1,4" to cancel the modal. But "1" works also. If "1" didn't work.. well.