Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken popup panel in Chromium 65 #1085

Closed
4 of 8 tasks
DDDespair opened this issue May 31, 2020 · 7 comments
Closed
4 of 8 tasks

Broken popup panel in Chromium 65 #1085

DDDespair opened this issue May 31, 2020 · 7 comments
Labels
Chromium specific to Chromium/Chrome external issue involving an external factor fixed issue has been addressed

Comments

@DDDespair
Copy link

DDDespair commented May 31, 2020

Prerequisites

  • I verified that this is not a filter issue

  • This is not a support issue or a question

  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue

    • Your issue may already be reported.
  • I tried to reproduce the issue when...

    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin

  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

I assume ublock just updated; now when clicking on the extension icon, I see https://i.imgur.com/SB4rPiB.png instead of the menu. I tried uninstalling/reinstalling and the issue is the same. My Win 10 PC is still on v. 1.26.0 and is working fine, as was this one until sometime in the last few days (haven't accessed the menu in some time). Right Click>Options still works.

A specific URL where the issue occurs

It really is everywhere, even new tab. Here's an arbitrary example I guess https://github.com/uBlockOrigin

Steps to Reproduce

  1. Click on the extension icon in Chromium

Expected behavior:

To see/access the filter options, elements zapper, dashboard, etc.

Actual behavior:

I see https://i.imgur.com/SB4rPiB.png instead of the menu.

Your environment

  • uBlock Origin version: v1.27.10
  • Browser Name and version: Chromium Version 65.0.3325.162 (Official Build) (64-bit)
  • Operating System and version: Win 7 64 Bit SP1

Is there at least a way to revert to v1.26.0? Since that worked without issue...

EDIT: While trying to import my filters/rules/white lists (since I uninstalled/reinstalled; I backed them up by exporting first), it seems the changes aren't saved even after hitting "apply changes." The entries just disappear as soon as I change from "my filters" to "my rules" to "whitelist." Direct copy/paste yields the same result, the entries aren't saved.

@uBlock-user uBlock-user added the something to address something to address label May 31, 2020
@gorhill
Copy link
Member

gorhill commented May 31, 2020

You are using an over 2-year old version of Chromium, best is that you investigate what the browser reports in uBO's dev console -- I won't be able to investigate this myself

I do expect people using old versions to investigate such issues and to actually use the dev build such that those issues are found before release.

@uBlock-user uBlock-user added Chromium specific to Chromium/Chrome external issue involving an external factor and removed something to address something to address labels May 31, 2020
@gorhill gorhill reopened this May 31, 2020
@gorhill
Copy link
Member

gorhill commented May 31, 2020

I want some feedback first -- Chromium 65 happens the be the version at which uBO will internally switch to the classic UI, because this version of Chromium does not appear to support well CSS grids.

I made a change which may or may not help, this will be in the next dev build. If this does not work, than those suffering the issue will have to investigate the issue.

gorhill added a commit to gorhill/uBlock that referenced this issue May 31, 2020
@uBlock-user uBlock-user added the information needed Further information is requested label May 31, 2020
@gorhill
Copy link
Member

gorhill commented May 31, 2020

The last dev build contains a change which may or may not fix the issue: https://github.com/gorhill/uBlock/releases/tag/1.27.11b2. Please report whether this fixes it or not.

@DDDespair
Copy link
Author

You are using an over 2-year old version of Chromium, best is that you investigate what the browser reports in uBO's dev console -- I won't be able to investigate this myself

I do expect people using old versions to investigate such issues and to actually use the dev build such that those issues are found before release.

Got it. I followed the instructions for the Dev console here https://old.reddit.com/r/uBlockOrigin/comments/9hsps5/chrome_dev_ublock_origin_not_blocking_any_ads_on/e6fmx1b/ but I must be doing something wrong as the console doesn't display anything https://i.imgur.com/Gu35FWO.png

Should I go ahead and try the latest dev build? I assume I'll have to manually load it like an unpacked extension, correct?

@gorhill
Copy link
Member

gorhill commented May 31, 2020

So no error at the console means uBO's call to browserAction.setPopup() appears to have succeeded. You can try the dev build to see if it makes any difference.

@DDDespair
Copy link
Author

So no error at the console means uBO's call to browserAction.setPopup() appears to have succeeded. You can try the dev build to see if it makes any difference.

The most recent beta does fix the menu not appearing. Loading filters still seems a little buggy; using "import and append" only loaded the first 4 filters. I just copy+pasted the rest and the changes did save correctly. Oddly, the list doesn't have a scrollbar for whatever reason. Whitelists imported and appended correctly.

@DAOWAce
Copy link

DAOWAce commented Jun 6, 2020

Chromium 62 here. (Cent v3.0.4)

The UI change to the options menu sparked my worry, and now I too found this issue when attempting to open the page UI to block an element.

I really hate how Chrome still auto-updates addons even in developer mode. What's the point of having an 'update extensions" button, Google? sigh

I can confirm the dev build UI works again, but it looks to be rendered a bit screwy (ie; with directwrite). Reverting to classic flyout has half the page looking normal (no directwrite), while the other half (the only one displayed in the new UI) looks DirectWrite rendered.

Wish I didn't have the problem of DirectWrite rendered UI causing me eye strain.. it's the sole reason I'm still on an old version of Chromium. Was using Chrome v51 before it became too broken and I had to switch to Cent.. then Google kept ruining things and the developer of it couldn't keep the font rendering the same, which in turn alienated people like me.

Worst case I'll just keep the 1.26 version of the extension as a backup and load it unpacked if the current version ever stops working. I doubt filter list subscriptions will critically break, at least for a long time.

@uBlock-user uBlock-user removed the information needed Further information is requested label Jun 6, 2020
@uBlock-user uBlock-user added the fixed issue has been addressed label Jun 18, 2020
@gorhill gorhill changed the title "Your file was not found"? Broken popup panel in Chromium 65 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium specific to Chromium/Chrome external issue involving an external factor fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants