Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for literal NaN delay in no-setTimeout-if/no-setInterval-if scriplets #1136

Closed
gorhill opened this issue Jul 2, 2020 · 0 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@gorhill
Copy link
Member

gorhill commented Jul 2, 2020

Related commit:

URL:

Filter:

  • gamesradar.com##+js(nosiif)

Discussion:

In the above commit, I erroneously assumed specifying a delay which value is converted to NaN would cause the scriptlet to match properly, but it doesn't, in the end this works because of the match against the function string.

It should be possible to specify literal NaN as delay in those scriptlets, in which case a typed comparison using isNaN() would be used.

@uBlock-user uBlock-user added the enhancement New feature or request label Jul 2, 2020
@gwarser gwarser added the fixed issue has been addressed label Jul 8, 2020
@gwarser gwarser closed this as completed Jul 8, 2020
JustOff pushed a commit to gorhill/uBlock-for-firefox-legacy that referenced this issue Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants