Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger doesn't display uritransform when filtering only uritransform #3126

Closed
8 of 9 tasks
Iz-zzzzz opened this issue Feb 15, 2024 · 4 comments
Closed
8 of 9 tasks

Logger doesn't display uritransform when filtering only uritransform #3126

Iz-zzzzz opened this issue Feb 15, 2024 · 4 comments
Labels
bug Something isn't working fixed issue has been addressed

Comments

@Iz-zzzzz
Copy link

Iz-zzzzz commented Feb 15, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

From #3125 but I enable only ||pantip.com^$doc,uritransform=/#lead:.*// rule.

A specific URL where the issue occurs.

`https://pantip.com/topic/41624586#lead:related:6B9mGrzkxFdzAeuBEWJhXs:6:https://pantip.com/topic/42521369`

Steps to Reproduce

  1. Create test.txt file in Desktop
  2. Allow uBO to access to file URLs
    image
  3. Import test.txt to uBO custom filters and add file:/// in trustedListPrefixes to make sure this filter have enough permission.
    image
  4. Add ||pantip.com^$doc,uritransform=/#lead:.*// rule to test.txt
  5. Save test.txt
  6. Click update filter
    image
  7. Open Logger
  8. go to https://pantip.com/topic/41624586#lead:related:6B9mGrzkxFdzAeuBEWJhXs:6:https://pantip.com/topic/42521369 site
  9. filter only uritransform in Logger

Expected behavior

There is uritransform list when filtering only uritransform type .

Actual behavior

Logger doesn't display uritransform list when filtering only "uritransform"
image

I need to search the word "uritransform" (when not filter type to display) to see the actual logs. (image below)
image

uBO version

1.55.1rc4

Browser name and version

Brave Browser Version 1.62.162 Chromium: 121.0.6167.164 (Official Build) (64-bit)

Operating System and version

Windows 11 Education 22H2

@Iz-zzzzz Iz-zzzzz changed the title Logger doesn't display uritransform list when filtering only uritransform Logger doesn't display uritransform when filtering only uritransform Feb 15, 2024
gorhill added a commit to gorhill/uBlock that referenced this issue Feb 15, 2024
@gorhill
Copy link
Member

gorhill commented Feb 15, 2024

Thanks for reporting. Side question: why use an external list for repro steps? Point 1 to 6 could just be:

  1. Add ||pantip.com^$doc,uritransform=/#lead:.*// rule to "My filters"

@Iz-zzzzz
Copy link
Author

Iz-zzzzz commented Feb 15, 2024

Thanks for reporting. Side question: why use an external list for repro steps? Point 1 to 6 could just be:

  1. Add ||pantip.com^$doc,uritransform=/#lead:.*// rule to "My filters"

Reasons:

  1. I forget whether $uritransform is need trusted permission or not (and I can't find any related document)
  2. I'm not sure whether MyFilter was removed from trusted source in past or not. (and I can't find what actual name of MyFilter to add to trusted source in case it was removed)
  3. I used to building my filter for Thai sites with this method which is always give trusted permission to my filter.
  4. I want to provide 100% accuracy how I repro steps.

number 2 to 3 to avoid not enough permission (just in case).

Thank you for always doing very good extension🫡.

@Iz-zzzzz
Copy link
Author

Thank you (●'◡'●)

@krystian3w
Copy link

forget whether

uri needs load from trusted resource.

not sure whether MyFilter was

Untrusted at stable, trusted in dev by user- (can be copied to uBo stable at own risk until someone made nice pr with text area in support tab with mechanic disable running pasted filters ~30 minutes after save).

@gwarser gwarser added bug Something isn't working fixed issue has been addressed labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants