Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve suggested candidate filters in element picker" #3220

Closed
9 tasks done
Yuki2718 opened this issue Apr 21, 2024 · 7 comments
Closed
9 tasks done

Revert "Improve suggested candidate filters in element picker" #3220

Yuki2718 opened this issue Apr 21, 2024 · 7 comments
Labels
bug Something isn't working fixed issue has been addressed

Comments

@Yuki2718
Copy link

Yuki2718 commented Apr 21, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Explained in https://github.com/uBlockOrigin/uBlock-discussions/discussions/889 but I'm opening an issue here hopefully to gather more opinion.

The change was made in gorhill/uBlock@c0b56cf and now the picker is sometimes useless - unable to choose ID or full href on many sites.

2024.4.SNS.X.Twitter.Instagram.LINE.TikTok.-.Google.Chrome.2024-04-21.17-06-53.mp4

A specific URL where the issue occurs.

https://www.comnico.jp/we-love-social/sns-users

Steps to Reproduce

  1. Visit the page and scroll down until the popup is shown
  2. Choose the selector having ID
  3. Move the slider around, you'll never be able to choose ID

Expected behavior

Previous one

Actual behavior

Explained

uBO version

1.57.3b5

Browser name and version

Chrome 123.0.6312.124

Operating System and version

Windows 10

@Yuki2718
Copy link
Author

Yuki2718 commented Apr 21, 2024

Unrelated but not something worth another issue, but I feel the height of the filters window in the picker is now too low. It should be higher or adjustable.

@gorhill
Copy link
Member

gorhill commented Apr 21, 2024

filters window

Are you talking about the text area of the list of candidates?

@garry-ut99

This comment was marked as abuse.

@Yuki2718
Copy link
Author

Are you talking about the text area of the list of candidates?

Yes.

which was necessary

Even for mobile it's too low IMO.

@gorhill
Copy link
Member

gorhill commented Apr 21, 2024

My question had a typo, which makes me unsure about your answer. Which part is not high enough? The text area or the list of candidates?

@Yuki2718
Copy link
Author

TBH both of them, but in particular the text area.

gorhill added a commit to gorhill/uBlock that referenced this issue Apr 22, 2024
@uBlock-user uBlock-user added bug Something isn't working fixed issue has been addressed labels Jun 13, 2024
@freezer2022
Copy link

I agree with Yuki2718, text area height is now often too low (inconvenient and cumbersome) when there is a need to view/edit/manage some very long filters, which can take more than 4 rows, and they just don't fit in the text area. Making the Picker window resizable or adding incerase height button would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

5 participants