Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse lookup occasionally fails for static filters created via Picker #968

Closed
uBlock-user opened this issue Mar 30, 2020 · 4 comments
Closed
Labels
bug Something isn't working fixed issue has been addressed

Comments

@uBlock-user
Copy link
Contributor

uBlock-user commented Mar 30, 2020

Description

As above and as discussed in https://github.com/orgs/uBlockOrigin/teams/ublock-issues-volunteers/discussions/176

A specific URL where the issue occurs

https://httpbin.org/

Steps to Reproduce

  • Add httpbin.org###operations-tag-HTTP_Methods to "My filters"
  • Open the logger
  • Navigate to https://httpbin.org/
  • Click #operations-tag-HTTP_Methods in the logger -- this invokes reverse-lookup code
  • Add any cosmetic filter via element picker for the same page
  • Force a reload of the page
  • Try to reverse-lookup the newly added filter
  • Result: no filter list found

Expected behavior:

Reverse lookup doesn't fail and reveals the filterlist

Actual behavior:

Reverse lookup fails.

Your environment

  • uBlock Origin version: 1.25.3rc0
  • Browser Name and version: Firefox 76
  • Operating System and version: Win 10
@uBlock-user uBlock-user added the bug Something isn't working label Mar 30, 2020
@gorhill
Copy link
Member

gorhill commented Mar 30, 2020

Reproduction may be difficult

It's not. As detailed in previous conversation, you just need to invoke the reverse-lookup code before adding a filter -- you are missing that crucial step in your STR:

  1. Add httpbin.org###operations-tag-HTTP_Methods to "My filters"
  2. Open the logger
  3. Navigate to https://httpbin.org/
  4. Click #operations-tag-HTTP_Methods in the logger -- this invokes reverse-lookup code
  5. Add any cosmetic filter via element picker for the same page
  6. Force a reload of the page
  7. Try to reverse-lookup the newly added filter
  8. Result: no filter list found

@uBlockOrigin uBlockOrigin deleted a comment from kangnaclub9 Apr 15, 2020
@gorhill gorhill changed the title Reverse lookup occasionally fails for cosmetic filters created via Picker when visiting a website for the first time Reverse lookup occasionally fails for static filters created via Picker Apr 21, 2020
@garry-ut99

This comment was marked as abuse.

@gorhill
Copy link
Member

gorhill commented Aug 25, 2023

might be helpful to investigate the issue

@gorhill
Copy link
Member

gorhill commented Aug 25, 2023

I knew what the issue was when I wrote my above comment, it's the fact that the compiled lists are loaded in the worker before the filter is created.

@uBlock-user uBlock-user added the fixed issue has been addressed label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants