Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed solid types path #963

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

aleksandrjet
Copy link
Contributor

According to the package.json, types should be located in esm folder:

"exports": {
  ".": {
    "types": "./esm/index.d.ts",
    "import": "./esm/index.js",
    "default": "./dist/solid-imask.js"
  },
}

But due to the settings in tsconfig.json they are generated in dist folder:

"compilerOptions": {
  "declarationDir": "./dist"
}

It throws an error:

Could not find a declaration file for module 'solid-imask'. 
'../node_modules/solid-imask/esm/index.js' implicitly has an 'any' type.
Try `npm i --save-dev @types/solid-imask` if it exists or 
add a new declaration (.d.ts) file containing `declare module 'solid-imask';`

@uNmAnNeR
Copy link
Owner

thanks

@uNmAnNeR uNmAnNeR merged commit 2274af3 into uNmAnNeR:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants