-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for custom i18n messages #326
feat: added support for custom i18n messages #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @rmathis! 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmathis it's a really nice improvment 👼
You forgot the hamburger-menu, could you activate it from the App.vue and add the missing part ?
And the "top notch" thing would be to have the documentation updated.
Thanks a lot
Note: for the hamburger-menu testing you can also add the property show-favorites-in-slider to switch between slider and content-grid.
Updated docs and added the mixin to the hamburger menu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmathis 👼
Added support for passing in a json string for customizing the i18n messages. Also separated the i18n logic into a mixin for all components to use.