Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc:merging attribute sources from Confluence(#2287) #2857

Closed
wants to merge 4 commits into from

Conversation

555vedant
Copy link
Contributor

This pull request adds configuration for the CachingPersonAttributeDaoImpl bean to the User Attributes documentation in README.md. The new bean merges user attribute sources, enhancing the flexibility and performance of user data retrieval in uPortal.

-> Changes Made

  1. Added a CachingPersonAttributeDaoImpl bean definition to improve attribute merging.
  2. Updated the documentation to guide users on configuring multiple user attribute sources effectively.

@555vedant
Copy link
Contributor Author

Respected Sir/Madam , If all fine then pls dont merge this PR till 1st of OCTOBER , because i am participating into the HACKTOBER fest.

@@ -72,6 +57,33 @@ of the more common ways is to declare them in a Spring XML configuration file wi
</property>
</bean>

<!-- CachingPersonAttributeDaoImpl Bean Definition -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this would be better located in docs/implement/user-attributes/jdbc.md. Additionally, the myunivCachingPersonDbJdbcAttributeSource example bean should be brought over as well.

@555vedant
Copy link
Contributor Author

i am just chnaging the Readme.md to its default because added those content into the jdbc.md

@555vedant

This comment was marked as duplicate.

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Sep 28, 2024

@555vedant thanks for taking time to contribute.
Yes, we understand you want this to be a part of hacktoberfest, all-caps shout-casing your message repeatedly is not necessary 🙂

@555vedant
Copy link
Contributor Author

@ChristianMurphy sir thanks

@jonathanmtran
Copy link
Contributor

Per https://hacktoberfest.com/participation/#pr-mr-details

Your PR/MRs must be created between October 1 and October 31 (in any time zone, UTC-12 thru UTC+14)

Since you are looking to participate in Hacktoberfest, I am going to close this PR.
After 1 October, please squash the commits in this branch down to one commit and then submit a new PR

@555vedant
Copy link
Contributor Author

@ChristianMurphy okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants