Merge pull request #324 from GeoffTK/fix-android-parsing

Update Android Regex to allow for single digit OS versions
ua-parser · Sep 14, 2018 · aa82669 · aa82669
2 parents a537607 + 5efbdcc
commit aa82669
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/regexes.yaml b/regexes.yaml
@@ -844,7 +844,7 @@ os_parsers:
   # Android
   # can actually detect rooted android os. do we care?
   ##########
-  - regex: '(Android)[ \-/](\d+)\.(\d+)(?:[.\-]([a-z0-9]+))?'
+  - regex: '(Android)[ \-/](\d+)\.?(\d+)?(?:[.\-]([a-z0-9]+))?'
 
   - regex: '(Android) Donut'
     os_v1_replacement: '1'

diff --git a/tests/test_os.yaml b/tests/test_os.yaml
@@ -2637,3 +2637,10 @@ test_cases:
     patch: 
     patch_minor: 
 
+  - user_agent_string: 'Mozilla/5.0 (Linux; Android 9; Pixel Build/PPP3.180510.008) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.81 Mobile Safari/537.36'
+    family: 'Android'
+    major: '9'
+    minor:
+    patch: 
+    patch_minor: 
+