Merge pull request #305 from asuhan/fix_espn_radio_podcast

Fix ESPN Radio podcast catcher regex
ua-parser · Mar 21, 2018 · fc570f3 · fc570f3
2 parents 225c891 + 0366e90
commit fc570f3
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/regexes.yaml b/regexes.yaml
@@ -478,7 +478,7 @@ user_agent_parsers:
     family_replacement: 'FancyMusic'
   - regex: 'EspnDownloadManager'
     family_replacement: 'ESPN'
-  - regex: '(ESPN) Radio (\d+)\.(\d+)\.?(\d+)? ?[rv:]?(\d+)? '
+  - regex: '(ESPN) Radio (\d+)\.(\d+)\.?(\d+)? ?(?:rv:(\d+))? '
   - regex: '(podracer|jPodder) v ?(\d+)\.(\d+)\.?(\d+)?'
   - regex: '(ZDM)/(\d+)\.(\d+)[; ]?'
   - regex: '(Zune|BeyondPod) (\d+)\.?(\d+)?[\);]'

diff --git a/tests/test_ua.yaml b/tests/test_ua.yaml
@@ -7405,4 +7405,29 @@ test_cases:
     family: 'IE'
     major: '11'
     minor: '0'
-    patch:
+    patch:
+
+  - user_agent_string: 'ESPN Radio/3.2.113 CFNetwork/485.12.30 Darwin/10.4.0'
+    family: 'ESPN'
+    major: '3'
+    minor: '2'
+    patch: '113'
+
+  - user_agent_string: 'ESPN Radio 4.7.4 rv:1032 (iPhone; iPhone OS 9.2.1; en_US)'
+    family: 'ESPN'
+    major: '4'
+    minor: '7'
+    patch: '4'
+    patch_minor: '1032'
+
+  - user_agent_string: 'ESPN Radio 4.5.1 (iPhone; iPhone OS 5.1.1; en_US)'
+    family: 'ESPN'
+    major: '4'
+    minor: '5'
+    patch: '1'
+
+  - user_agent_string: 'ESPN Radio 4.0 (iPhone; iPhone OS 7.1.2; en_AU)'
+    family: 'ESPN'
+    major: '4'
+    minor: '0'
+    patch: