-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification #1
Conversation
@tobie: The spec contains an yet unsuported status. I'll prepare a PR on the core parser which covers these aspects. Hope thats fine. |
That's great. Could you please change occurrences of formal language (e.g. "shall") do something that sounds a little more casual? We don't want to make the task of implementing the spec properly to sound more daunting than it really is. :) |
Specs are no poems :) . I think specs "shall" be very specific to make clear what to do and what not to do. The terms of "may" "should" and "shall"/ "must" are very established. See http://www.ietf.org/rfc/rfc2119.txt. |
Care to use "must" instead of "shall", then? It reads better. :) |
|
||
# ua-parser Specification | ||
|
||
This document describes the specification on how a parser should implement the `regexes.yaml` file for correctly parsing user-agent strings on basis of that file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be a "must", then.
Think we should also add a section that describes what the API provided by the parser should look like. Using WebIDL or some other generic IDL. |
Hope I got your points updated right. Reading should be less offensive now. |
Thanks! |
Add test to test_user_agent_parser.yaml
Add test to test_user_agent_parser.yaml
Update forked repo from upstream master
This PR contains the draft for specifying the ua-parser behaviour together with the contents of the regexes.yaml file.
Note: Spec contains brand-model parsing as well as regex flag.