Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification #1

Merged
merged 2 commits into from
Feb 28, 2014
Merged

Specification #1

merged 2 commits into from
Feb 28, 2014

Conversation

commenthol
Copy link
Contributor

This PR contains the draft for specifying the ua-parser behaviour together with the contents of the regexes.yaml file.
Note: Spec contains brand-model parsing as well as regex flag.

@commenthol
Copy link
Contributor Author

@tobie: The spec contains an yet unsuported status. I'll prepare a PR on the core parser which covers these aspects. Hope thats fine.

@tobie
Copy link
Contributor

tobie commented Feb 28, 2014

That's great. Could you please change occurrences of formal language (e.g. "shall") do something that sounds a little more casual? We don't want to make the task of implementing the spec properly to sound more daunting than it really is. :)

@commenthol
Copy link
Contributor Author

Specs are no poems :) . I think specs "shall" be very specific to make clear what to do and what not to do. The terms of "may" "should" and "shall"/ "must" are very established. See http://www.ietf.org/rfc/rfc2119.txt.

@tobie
Copy link
Contributor

tobie commented Feb 28, 2014

Care to use "must" instead of "shall", then? It reads better. :)


# ua-parser Specification

This document describes the specification on how a parser should implement the `regexes.yaml` file for correctly parsing user-agent strings on basis of that file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be a "must", then.

@tobie
Copy link
Contributor

tobie commented Feb 28, 2014

Think we should also add a section that describes what the API provided by the parser should look like. Using WebIDL or some other generic IDL.

@commenthol
Copy link
Contributor Author

Hope I got your points updated right. Reading should be less offensive now.

@tobie
Copy link
Contributor

tobie commented Feb 28, 2014

Thanks!

tobie added a commit that referenced this pull request Feb 28, 2014
@tobie tobie merged commit 6fe4a8a into ua-parser:master Feb 28, 2014
commenthol pushed a commit that referenced this pull request Nov 29, 2014
Add test to test_user_agent_parser.yaml
davemarchevsky pushed a commit to davemarchevsky/uap-core that referenced this pull request Feb 18, 2015
Add test to test_user_agent_parser.yaml
commenthol pushed a commit that referenced this pull request Sep 19, 2015
Update forked repo from upstream master
commenthol pushed a commit that referenced this pull request Nov 24, 2015
commenthol pushed a commit that referenced this pull request Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants