Fix patch version parsing for Facebook and Pinterest app #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commenthol
reviewed
Aug 30, 2017
tests/test_ua.yaml
Outdated
| @@ -6381,11 +6381,11 @@ test_cases: | |||
| minor: '4' | |||
| patch: | |||
|
|
|||
| - user_agent_string: '[FBAN/FB4A;FBAV/2.3;FBBV/149649;FBDM/{density=1.5,width=480,height=800};FBLC/es_ES;FBCR/;FBPN/com.facebook.katana;FBDV/LG-P920;FBSV/2.2.2;]' | |||
There was a problem hiding this comment.
Please do not delete/change a previous UA-String. Add a new one instead.
commenthol
reviewed
Aug 30, 2017
tests/test_ua.yaml
Outdated
| @@ -6501,11 +6501,11 @@ test_cases: | |||
| minor: '3' | |||
| patch: '1' | |||
|
|
|||
| - user_agent_string: 'Pinterest for Android/1.1.1 (endeavoru; 4.1.1)' | |||
There was a problem hiding this comment.
Please do not delete/change a previous UA-String. Add a new one instead.
The patch number was wrongly captured.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular expression was capturing just last digit of patch version.