Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several agents related to Nextcloud #282

Merged
merged 6 commits into from
Nov 18, 2017
Merged

Add several agents related to Nextcloud #282

merged 6 commits into from
Nov 18, 2017

Conversation

sclu1034
Copy link
Contributor

@sclu1034 sclu1034 commented Nov 11, 2017

  • ab576d9 adds Evolution's user agent for "on the web" calendars and address books.
  • 820bf4d adds Roundcube's CardDAV plugin. Prior to v0.9.0 (about three years ago) they used RCM CardDAV plugin/TRUNK between releases, not sure whether I should add that as well. After v0.9.0 they changed to a -dev suffix which I added to the regex.
  • ff51462 adds the app DAVdroid. They use version suffixes depending on where you download the app (e.g. 1.9.2-gplay on Google Play, 1.9-ose on F-Droid), not sure if I should add these to the version output.
    I also had to put this quite high in the SPECIAL CASES TOP as they include OkHttp in their user agent which is matched as a "downloader..." (add okhttp #185).
  • 631c5e4 adds the Nextcloud desktop sync application. The Owncloud version could probably be added to that regex as well, but I don't have anything to test it with.
  • 5aa11ba adds the official Nextcloud android app. Sadly the app didn't change its user agent after forking from the Owncloud version, so they still send owncloud-android.

@sclu1034 sclu1034 changed the title Add several agents related to CardDAV/CalDAV Add several agents related to Nextcloud Nov 12, 2017
@commenthol commenthol merged commit 157160a into ua-parser:master Nov 18, 2017
@commenthol
Copy link
Contributor

Thanks for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants