updated test cases and family name for SznProhlizec

[panther7]

^ @bambooCZ

[panther7]

Thank you for future merge ;-)

[janRucka]

+1
Good work

[sunknudsen]

@panther7 Thanks for the pull request. :)

Why not use (SznProhlizec)\/(\d+)\.(\d+)\.(\d+)?

According to your unit tests in tests/test_ua.yaml, this simplified regex would works just as well.

Perhaps you are addressing other user agent strings that are not part of the unit tests.

[panther7]

@sunknudsen Because, I don't want "-12345" in patch version. This doesn't affect public releases but internal releases can have this suffix. Thanks for understand ;-)

(SznProhlizec)\/(\d+)\.(\d+)\.(\d+) dismatch SznProhlizec/4.4i

[sunknudsen]

@panther7 According to spec \d+ will only match digits from 0-9 so the match would stop before the -.

https://regexr.com/3lvd6

@commenthol Should contributors add unit tests for internal release use cases such as #304 (comment) to tests/test_ua.yaml?

@sunknudsen Because, I don't want "-12345" in patch version. This doesn't affect public releases but internal releases can have this suffix. Thanks for understand ;-)

(SznProhlizec)/(\d+).(\d+).(\d+) dismatch SznProhlizec/4.4i

[panther7]

@sunknudsen ... :-/

(SznProhlizec)/(\d+).(\d+).(\d+) dismatch SznProhlizec/4.4i

But I could use (SznProhlizec)\/(\d+)\.(\d+)(?:\.(\d+))? ...but this is same like before :)

[sunknudsen]

@panther7 Thanks for updating the test. Waiting for the feedback of @commenthol about documenting internal use cases before merging your pull request. I'm new to the project so want to make sure I respect conventions. Have a nice day!

[commenthol]

Commit 45fb215 looks good to me. Well (\d+)\.(\d+)(?:\.(\d+))? is often used if versions consists of either two or three digits.

[JakeChampion]

I believe this is the first instance of a non-ASCII family value. This will cause issues for those wanting to use the family value in a HTTP header as they are only US-ASCII. Would it be possible to have an ASCII based alternative value as well? E.G. family_replacement_ascii: 'Seznam.cz'