Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Instagram" app #307

Merged
merged 5 commits into from
Apr 6, 2018
Merged

Add "Instagram" app #307

merged 5 commits into from
Apr 6, 2018

Conversation

matAtWork
Copy link
Contributor

Added tests for Android and iOS strings as seen in the wild, both passing with expected results.

@sunknudsen
Copy link
Contributor

sunknudsen commented Mar 9, 2018

@matAtWork Thanks for the pull request. :) Is there a reason why you used . instead of (space character) to match spaces in your regexes?

@commenthol What’s our policy for additions to .gitignore?

@commenthol
Copy link
Contributor

I have no objection with regards to .gitignore additions.
package-lock.json is ok as it does not hurt - there are no updates published on npm.
/.project is difficult for me to classify as it seams to be something internal. So I would say this could be removed.

@matAtWork
Copy link
Contributor Author

@sunknudsen - No deep reasoning in using . over . Feel free to update if you prefer.

@commenthol - .project was created by my editor. Again there's no good reason to either include or exclude it from .gitignore, but it's convenient for me personally :)

If you wish me to make and push these changes, let me know, otherwise I'll let you proceed as you see fit.

@sunknudsen
Copy link
Contributor

@matAtWork Please remove .project and we’re good to go. Thanks Mat!

@matAtWork
Copy link
Contributor Author

Apologies for the delay. .project is now ignored and latest changes pulled. Please let me know if you need me to do anything else.

@sunknudsen
Copy link
Contributor

Thanks @matAtWork. I removed .project from .gitignore as this line is editor-specific. Thanks for your contribution to the project.

@sunknudsen sunknudsen merged commit 184fe9f into ua-parser:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants