-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regexes update #363
regexes update #363
Conversation
incompatible module dependencies
@@ -397,7 +397,7 @@ user_agent_parsers: | |||
|
|||
# HipChat provides a version on Mac, but not on Windows. | |||
# Needs to be before Chrome on Windows, and AppleMail on Mac. | |||
- regex: '(HipChat)/?(\d+)?' | |||
- regex: '(HipChat)/?(\d+|)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why add |
become safer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see http://www.regular-expressions.info/catastrophic.html?wlr=1
(\d+)?
nests repetition operators where (\d+|)
avoids this
Make the world a bit safer...