Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests and rules for PTST Webpagetest.org spiders #365

Merged
merged 3 commits into from
Jan 12, 2019

Conversation

kingo55
Copy link

@kingo55 kingo55 commented Dec 18, 2018

PR for #364

@kingo55
Copy link
Author

kingo55 commented Dec 18, 2018

That's weird - I get these values for the useragent strings in our Snowplow dataset (first few fields are another UA library, next is the raw useragent, next fields are UAP):

os_name	br_name	br_version	useragent	useragent_family	useragent_major	useragent_minor	useragent_patch	device_family
Windows 8.1	Internet Explorer 11	11.0	Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko PTST/1.0	IE	11	0		Other
Windows 8	Chrome 64	64.0.3282.0	Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.0 Safari/537.36 PTST/1.0	Chrome	64	0	3282	Other

@commenthol commenthol merged commit ca9a78e into ua-parser:master Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants