Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes case where Palo Alto identifies with multiple versions of Windows. #393

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Fixes case where Palo Alto identifies with multiple versions of Windows. #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions regexes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,6 +964,10 @@ os_parsers:
- regex: '(Windows ?Mobile)'
os_replacement: 'Windows Mobile'

- regex: '(Windows 10)'
os_replacement: 'Windows'
os_v1_replacement: '10'

- regex: '(Windows (?:NT 5\.2|NT 5\.1))'
os_replacement: 'Windows'
os_v1_replacement: 'XP'
Expand Down Expand Up @@ -1006,10 +1010,6 @@ os_parsers:
os_replacement: 'Windows'
os_v1_replacement: '10'

- regex: '(Windows 10)'
os_replacement: 'Windows'
os_v1_replacement: '10'

- regex: '(Windows NT 5\.0)'
os_replacement: 'Windows'
os_v1_replacement: '2000'
Expand Down
7 changes: 7 additions & 0 deletions tests/test_os.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,13 @@ test_cases:
patch:
patch_minor:

- user_agent_string: 'PAN GlobalProtect/5.0.0-87 (Microsoft Windows 10 Pro , 64-bit) Mozilla/5.0 (Windows NT 6.2; Win64; x64; Trident/7.0; rv:11.0) like Gecko'
family: 'Windows'
major: '10'
minor:
patch:
patch_minor:

- user_agent_string: 'Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko'
family: 'Windows'
major: '8'
Expand Down