Skip to content
This repository has been archived by the owner on Jan 5, 2019. It is now read-only.

Modified the Collection form to reflect the HN data dictionary #156

Merged
merged 3 commits into from
Mar 30, 2015

Conversation

weiweishi
Copy link
Contributor

as part of #30

Also removed the duplicated methods in collection_controller_behavior.rb (those that were not changed and are extra duplicate of methods in Sufia and will be inherited from Sufia)

@pgwillia
Copy link
Member

This looks good. rspec spec-views/collection_form_spec.rb pass but running rspec spec-views stalls. This is the same behaviour I get on master. I'm comfortable merging 👍

pgwillia added a commit that referenced this pull request Mar 30, 2015
Modified the Collection form to reflect the HN data dictionary
@pgwillia pgwillia merged commit c891102 into master Mar 30, 2015
@weiweishi weiweishi mentioned this pull request Apr 10, 2015
@pgwillia pgwillia deleted the collection-form branch April 15, 2015 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants