This repository has been archived by the owner on Dec 22, 2022. It is now read-only.
Symphony nightly migration foreign key error #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgwillia
requested review from
mbarnett,
a user,
lagoan,
murny,
nmacgreg and
ConnorSheremeta
When I try to rename the library_id column to backup_library_id a foreign key constraint is broken. The bug was hidden using MySQL 5.7 but not in MySQL 5.5 which is used by staging and production. By first removing the foreign key constraint then renaming the column and finally restoring the foreign key there aren't any invalid constriants at any time.
mbarnett
approved these changes
Jan 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We're trying to automate data flowing from Symphony configuration files to Discovery to provide user better labels in the holdings table.
When we tried the two steps (
rails g symphony_nightlyrake db:migrate) in staging/production we encountered a failure in the migration and complains about foreign key constraints. There was a bug in the migration template that was hidden in development/test because a different, more tolerant version of MySQL was being used (5.7 vs 5.5 in production)Related to #2142
What's New