Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: session feedback #129 #134

Merged
merged 2 commits into from
Apr 1, 2024
Merged

feat: session feedback #129 #134

merged 2 commits into from
Apr 1, 2024

Conversation

georgfrodo
Copy link
Collaborator

closes #129

@georgfrodo georgfrodo requested a review from rbento1096 March 29, 2024 14:19
@georgfrodo georgfrodo self-assigned this Mar 29, 2024
Copy link
Collaborator

@rbento1096 rbento1096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some changes after testing:

  • new fields (ratings and comments) on the session model were not loaded in the model, so they would be lost on if the session was edited
  • In the back-end, you can't do 2 UPDATE operation on the same object, I refactored to make the comments update separate
  • The comments and ratings fields did not exist on the existing data in the DB so the UPDATE also failed there. I made a script that added these fields to all records on the DB.
  • The feedback conditionals (hasUserRated and hasSessionEnded) were working but the parent components were not updating the value on the child component.
  • As a plus, I added custom error messages to the front-end depending on the cause of the feedback action failing.
  • Changed the star color to yellow as the gray made it difficult to distinguish ratings when we are giving 5 stars.

Most of these errors were minimal or were back-end related (which you didn't have a way to test ofc) so all in all I'd say it's a great job!
Really liked the UI for the feedback as well! Both when submitting the feedback as well as the little info announcing a user has already submitted feedback for a session

Thanks a lot @georgfrodo

@rbento1096 rbento1096 merged commit 1546bd8 into development Apr 1, 2024
@uatisdeproblem uatisdeproblem deleted the 129-session-feedback branch April 5, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants