Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] bookmark button does nothing #68

Closed
aluo-x opened this issue Jul 17, 2023 · 4 comments
Closed

[BUG] bookmark button does nothing #68

aluo-x opened this issue Jul 17, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@aluo-x
Copy link

aluo-x commented Jul 17, 2023

Version: https://github.com/uazo/bromite-buildtools/releases/tag/v114.0.5735.199-af55aa0ddfc47fbaffafd60c385d4c43c7c5ad0c

Problem description: It seems like after bromite is open for a while, you can no longer bookmark pages. Pressing the bookmark button does nothing. Restarting bromite typically works.
@uazo
Copy link
Owner

uazo commented Jul 19, 2023

please try to check with the latest version (v115)

@uazo uazo transferred this issue from uazo/bromite-buildtools Jul 19, 2023
@aluo-x
Copy link
Author

aluo-x commented Jul 20, 2023

Thank you uazo for the update. I can confirm that it is still broken on 115.

After the browser is open for a few hours, pressing the bookmark button no longer does anything. Closing the browser and then opening it again restores the functionality.

@uazo
Copy link
Owner

uazo commented Jul 20, 2023

Yes, I finally found the bug.
thanks for the report, will be fixed in the next release

@uazo uazo added the bug Something isn't working label Jul 20, 2023
uazo added a commit that referenced this issue Jul 20, 2023
@uazo
#68 - Fix crash when opening BookmarkActivity
996ab2d
@uazo uazo mentioned this issue Jul 21, 2023
Closed
@uazo uazo closed this as completed Jul 21, 2023
@aluo-x
Copy link
Author

aluo-x commented Sep 17, 2023

It appears this problem has reappeared in v117.0.5938.63-579060fe5105c0cfcb35e5ee35a3f6c921ec0791

@aluo-x aluo-x mentioned this issue Sep 17, 2023
Closed
@aluo-x aluo-x mentioned this issue Apr 13, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aluo-x @uazo