Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmarks #100

Merged
merged 5 commits into from
Nov 21, 2022
Merged

add benchmarks #100

merged 5 commits into from
Nov 21, 2022

Conversation

joehattori
Copy link
Contributor

Resolves #94

@joehattori joehattori self-assigned this Nov 21, 2022
Copy link
Collaborator

@arshiamoghimi arshiamoghimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some quick changes. All the functions work correctly. Just some minor issues.

@@ -0,0 +1,15 @@
import markdown
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need the license file for this. I got it originally from here.

@@ -0,0 +1,2 @@
This benchmark is from [https://github.com/danielireson/formplug](https://github.com/danielireson/formplug).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but we might need to include the source code itself as well.

@@ -0,0 +1,2 @@
This benchmark is taken from [https://github.com/chronograph-pe/lambda-OCRmyPDF](https://github.com/chronograph-pe/lambda-OCRmyPDF).
Running `./deploy.sh` deploys the function to AWS.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script is empty

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the function package itself as well.

@joehattori joehattori force-pushed the feature/lambda-benchmark branch from b59fb03 to e570176 Compare November 21, 2022 22:04
@joehattori joehattori force-pushed the feature/lambda-benchmark branch from e570176 to 928d39b Compare November 21, 2022 22:15
@arshiamoghimi arshiamoghimi merged commit 08ed093 into master Nov 21, 2022
@joehattori joehattori deleted the feature/lambda-benchmark branch November 27, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porting existing benchmarks
2 participants