feat: add execution time threshold handling. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MehdiBC
changed the title
arshiamoghimi
requested changes
Jun 2, 2023
Comment on lines
21
to
22
| mems = np.delete(mems, i) | ||
| costs = np.delete(costs, i) |
There was a problem hiding this comment.
This is not a safe delete. An example:
| import numpy as np | ||
| import pandas as pd | ||
|
|
||
| from spot.exceptions import NoMemoryLeft |
There was a problem hiding this comment.
This should be
from spot.exceptions.NoMemoryLeft import NoMemoryLeftI get this error when running the code:
Format with Black
…c-cirrus-lab/ubc-SPOT into mehdi/execution_time_handling
arshiamoghimi
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The developer adds to the configuration file the execution time threshold .
Nothing changes in the exploration logic.
After fitting the function, we return the memory that minimizes the cost, with the constraint that the execution time is less than the threshold.