Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License #154

Merged
merged 4 commits into from
Oct 21, 2023
Merged

License #154

merged 4 commits into from
Oct 21, 2023

Conversation

engshahrad
Copy link
Collaborator

@arshiamoghimi can you review that:

Also, the setup file (https://github.com/ubc-cirrus-lab/parrotfish/blob/license/setup.py) states,"TODO: Update license attribute". Can you take care of that in this branch?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution.

If you've spotted a mistake that you'd like to see fixed, please create an issue instead. This PR will be closed shortly.

@github-actions github-actions bot closed this Oct 21, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution.

If you've spotted a mistake that you'd like to see fixed, please create an issue instead. This PR will be closed shortly.

@engshahrad engshahrad added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 21, 2023
@engshahrad
Copy link
Collaborator Author

engshahrad commented Oct 21, 2023

Why did it get closed @arshiamoghimi ? I don't think we need this way to handling PRs.

@engshahrad engshahrad reopened this Oct 21, 2023
@arshiamoghimi arshiamoghimi merged commit e8cde92 into master Oct 21, 2023
@arshiamoghimi arshiamoghimi deleted the license branch October 21, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants