Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth out development environment setup #17

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Smooth out development environment setup #17

merged 1 commit into from
Jan 27, 2022

Conversation

jpzg
Copy link
Contributor

@jpzg jpzg commented Jan 27, 2022

Dependencies and setup tasks are listed explicitly in README.md, and
installing requirements is simplified to one command. I also made the
whole package runnable as

$ spot

but that's mostly for convenience - when we're building a more
fleshed-out CLI, we'll probably want to clean up the package structure a
bit and change the entry point from main to a specific CLI script.

Dependencies and setup tasks are listed explicitly in README.md, and
installing requirements is simplified to one command. I also made the
whole package runnable as

$ spot

but that's mostly for convenience - when we're building a more
fleshed-out CLI, we'll probably want to clean up the package structure a
bit and change the entry point from main to a specific CLI script.
@jpzg jpzg requested a review from efeberkeevci January 27, 2022 19:14
@efeberkeevci efeberkeevci reopened this Jan 27, 2022
@efeberkeevci efeberkeevci merged commit c7cb8f7 into master Jan 27, 2022
@efeberkeevci efeberkeevci deleted the dev-env branch January 27, 2022 19:37
Copy link
Contributor

@efeberkeevci efeberkeevci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriklangille
Copy link
Contributor

Should we have a setup.sh that does that steps laid out in the readme? Otherwise lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants