Format with black #28
Conversation
|
Yeah good idea, let's merge it |
| self.ml_model = LinearRegressionModel(self.config["function_name"], self.config["vendor"], self.config["DB_URL"], self.config["DB_PORT"], self.config["last_log_timestamp"], benchmark_dir)#TODO: Parametrize ML model constructor with factory method | ||
| # Instantiate SPOT system components | ||
| self.price_retriever = AWSPriceRetriever( | ||
| self.config["DB_URL"], self.config["DB_PORT"], self.config["region"] |
There was a problem hiding this comment.
There is an inconsistency here compared to below multi-parameter object instantiatations.
There was a problem hiding this comment.
It's based on line length. These three can all fit on the same line (just not the line with the assignment), so it leaves them that way, but the others don't, so they get split up.
| def __init__(self, host, stage, resource, service='execute-api', content='application/x-amz-json-1.0') -> None: | ||
| self.access_key = os.environ.get('AWS_ACCESS_KEY_ID') | ||
| self.secret_key = os.environ.get('AWS_SECRET_ACCESS_KEY') | ||
| def __init__( |
There was a problem hiding this comment.
I don't find this multi-line parameter formatting useful for easier code reading
There was a problem hiding this comment.
It does this when a line is too long. I don't think it's as good as having everything one one line if it's only a few parameters, but to me it seems more readable than one very long line.
| payload_hash = hashlib.sha256(payload.encode('utf-8')).hexdigest() | ||
| canonical_uri = '/' + self.stage + '/' + self.resource | ||
| canonical_request = method + '\n' +canonical_uri +'\n' + canonical_querystring + '\n' + canonical_headers + '\n' + signed_headers + '\n' + payload_hash | ||
| canonical_querystring = "" |
There was a problem hiding this comment.
I actually don't think this line was very readable either way; it would probably be better as a multiline f-string like this:
f"""
{method}
{canonical_uri}
{canonical_querystring}
...
"""(there might be some whitespace issues in my example)
But it's kind of moot since this code is all removed in #27.
Formatting all our code with
blackgives us easy, consistent styling. If we want to adopt it, I can set up an action to apply it to every PR automatically.